From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: fs: dax: do not build on ARC or SH Date: Mon, 23 Feb 2015 13:56:34 -0800 Message-ID: <20150223215634.GA23928@roeck-us.net> References: <5778538.KJ98x3yxkB@wuerfel> <20150223184025.GD2780@wil.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Arnd Bergmann , Geert Uytterhoeven , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Andrew Morton , linux-sh@vger.kernel.org, Vineet Gupta To: Matthew Wilcox Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:53554 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbbBWV4t (ORCPT ); Mon, 23 Feb 2015 16:56:49 -0500 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1YQ0zg-000Vu9-DO for linux-fsdevel@vger.kernel.org; Mon, 23 Feb 2015 21:56:48 +0000 Content-Disposition: inline In-Reply-To: <20150223184025.GD2780@wil.cx> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Feb 23, 2015 at 01:40:25PM -0500, Matthew Wilcox wrote: > On Mon, Feb 23, 2015 at 12:29:45PM +0100, Arnd Bergmann wrote: > > The DAX implementation relies on the architecture to provide a working > > copy_user_page() function, as reported by Michael Ellerman's kisskb > > build bot: > > > > fs/dax.c: error: implicit declaration of function 'copy_user_page' [-Werror=implicit-function-declaration]: => 266:2 > > > > We already have a list of architectures that are known to be incompatible, > > but the list is missing ARC and SH at the moment. Further, blackfin and > > c6x also lack support for this function, but are already excluded because > > they do not support MMU-based kernels. > > I've got a short list of patches for DAX; I'll add this one to the list. > > Have the maintainers of these architectures been notified that they're > missing a core piece of kernel functionality? > Guess there a philosophical difference in opinion if the architecture code should (have to) provide copy_user_page() or not outside the architecture code itself. After all, fs/dax.c _is_ the only user of this function outside the architecture code. Guenter