From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Maxim Patlasov <MPatlasov@parallels.com>,
Robert Baldyga <r.baldyga@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
Felipe Balbi <balbi@ti.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] split struct kiocb
Date: Tue, 24 Feb 2015 03:47:07 +0000 [thread overview]
Message-ID: <20150224034707.GL29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150223213947.GI29656@ZenIV.linux.org.uk>
On Mon, Feb 23, 2015 at 09:39:47PM +0000, Al Viro wrote:
> On Mon, Feb 23, 2015 at 10:22:24PM +0100, Christoph Hellwig wrote:
> > On Mon, Feb 23, 2015 at 09:20:59PM +0000, Al Viro wrote:
> > > PS: I would prefer to rebase #iov_iter and #gadget to -rc1, actually...
> >
> > Btw, any chance to sneak dup_iter to Linus for this release? I ended
> > up adding an opencoded version to the block layer for this merge window,
> > and I'd prefer to get these consolidated ASAP.
>
> Hmm... Let's wait for USB folks to review those fixes - dup_iter() is
> helper needed for a fix of easily triggered use-after-free bug, after
> all, and beginning of the cycle is obviously OK for such.
While we are at it - once the situation with USB patches gets resolved,
I'm going to put that into vfs.git. If nothing else, O_DIRECT, O_APPEND and
probably O_NDELAY as well, need to be mirrored into ->ki_flags, to deal with
races on flipping those suckers during ->{read,write}_iter(). That, and
followup patches to affected filesystems out to go through vfs.git.
Another thing is that rw_copy_check_uvector() should be split in two helpers -
one to have iov_iter_init() folded into it, another being equivalent to
passing CHECK_IOVEC_ONLY (sg_io() and foreign address space treatment in
process_vm_readv()). Also vfs.git fodder, obviously, and should be on
top of that stuff.
next prev parent reply other threads:[~2015-02-24 3:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 18:00 [RFC] split struct kiocb Christoph Hellwig
2015-02-23 18:00 ` [PATCH 01/12] new helper: dup_iter() Christoph Hellwig
2015-02-23 18:00 ` [PATCH 02/12] move iov_iter.c from mm/ to lib/ Christoph Hellwig
2015-02-23 18:00 ` [PATCH 03/12] gadget/function/f_fs.c: close leaks Christoph Hellwig
2015-02-23 18:00 ` [PATCH 04/12] gadget/function/f_fs.c: use put iov_iter into io_data Christoph Hellwig
2015-02-23 18:00 ` [PATCH 05/12] gadget/function/f_fs.c: switch to ->{read,write}_iter() Christoph Hellwig
2015-02-23 18:00 ` [PATCH 06/12] gadgetfs: use-after-free in ->aio_read() Christoph Hellwig
2015-03-08 10:07 ` Ming Lei
2015-03-09 15:18 ` Michal Nazarewicz
2015-02-23 18:00 ` [PATCH 07/12] gadget: switch ep_io_operations to ->read_iter/->write_iter Christoph Hellwig
2015-02-23 18:00 ` [PATCH 08/12] fs: remove ki_nbytes Christoph Hellwig
2015-02-23 18:00 ` [PATCH 09/12] fuse: handle synchronous iocbs internally Christoph Hellwig
2015-03-06 2:54 ` Maxim Patlasov
2015-02-23 18:00 ` [PATCH 10/12] fs: don't allow to complete sync iocbs through aio_complete Christoph Hellwig
2015-02-23 18:00 ` [PATCH 11/12] fs: split generic and aio kiocb Christoph Hellwig
2015-02-23 18:00 ` [PATCH 12/12] fs: move struct kiocb to fs.h Christoph Hellwig
2015-02-23 21:20 ` [RFC] split struct kiocb Al Viro
2015-02-23 21:22 ` Christoph Hellwig
2015-02-23 21:39 ` Al Viro
2015-02-24 3:47 ` Al Viro [this message]
2015-02-23 21:23 ` Felipe Balbi
2015-02-23 21:42 ` Al Viro
2015-02-23 21:50 ` Felipe Balbi
2015-02-25 17:13 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2015-01-27 17:55 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224034707.GL29656@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=MPatlasov@parallels.com \
--cc=balbi@ti.com \
--cc=hch@lst.de \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).