From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vyacheslav Dubeyko <slava@dubeyko.com>,
Sougata Santra <sougata@tuxera.com>,
Christoph Hellwig <hch@lst.de>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] hfsplus: add missing curly braces in hfsplus_delete_cat()
Date: Wed, 25 Feb 2015 21:50:49 +0300 [thread overview]
Message-ID: <20150225185048.GH5116@mwanda> (raw)
In-Reply-To: <CABikg9wB=dvc3Jv4JYU0ZEGaXr=1QniW15MUgBygLnu_229ORQ@mail.gmail.com>
On Wed, Feb 25, 2015 at 07:37:47PM +0100, Sergei Antonov wrote:
> On 25 February 2015 at 19:30, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > Gar. No, I don't care about "if (unlikely(err < 0)" or
> > "if (unlikely(err)) ". Those seem like petty things to me so I'm not
> > getting involved with the argument between the two of you. (My secret
> > real opinion, is that I doubt anyone benchmarked it so probably the
> > unlikely() annotations hurt readability for no good reason. In other
> > words, "if (err)" is correct.)
>
>
> Thanks for drawing attention to this code anyway.
No problem. Please give me a Reported-by if you fix the static checker
warning.
regards,
dan carpenter
next prev parent reply other threads:[~2015-02-25 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:36 [patch] hfsplus: add missing curly braces in hfsplus_delete_cat() Dan Carpenter
2015-02-25 14:50 ` Sergei Antonov
2015-02-25 17:13 ` Dan Carpenter
2015-02-25 18:20 ` Sergei Antonov
2015-02-25 18:30 ` Dan Carpenter
2015-02-25 18:37 ` Sergei Antonov
2015-02-25 18:50 ` Dan Carpenter [this message]
2015-02-25 17:42 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225185048.GH5116@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=saproj@gmail.com \
--cc=slava@dubeyko.com \
--cc=sougata@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).