From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] hfsplus: add missing curly braces in hfsplus_delete_cat() Date: Wed, 25 Feb 2015 21:50:49 +0300 Message-ID: <20150225185048.GH5116@mwanda> References: <20150225133644.GW19745@mwanda> <20150225171303.GF5116@mwanda> <20150225183041.GG5116@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Vyacheslav Dubeyko , Sougata Santra , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , kernel-janitors@vger.kernel.org To: Sergei Antonov Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:35367 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbbBYSvE (ORCPT ); Wed, 25 Feb 2015 13:51:04 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Feb 25, 2015 at 07:37:47PM +0100, Sergei Antonov wrote: > On 25 February 2015 at 19:30, Dan Carpenter wrote: > > Gar. No, I don't care about "if (unlikely(err < 0)" or > > "if (unlikely(err)) ". Those seem like petty things to me so I'm not > > getting involved with the argument between the two of you. (My secret > > real opinion, is that I doubt anyone benchmarked it so probably the > > unlikely() annotations hurt readability for no good reason. In other > > words, "if (err)" is correct.) > > > Thanks for drawing attention to this code anyway. No problem. Please give me a Reported-by if you fix the static checker warning. regards, dan carpenter