From: Dave Chinner <david@fromorbit.com>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Jens Axboe <axboe@fb.com>, Brian Foster <bfoster@redhat.com>,
fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] brd: Only request 4K sectors if DAX is enabled
Date: Fri, 27 Feb 2015 11:23:02 +1100 [thread overview]
Message-ID: <20150227002302.GF18360@dastard> (raw)
In-Reply-To: <54EEDC4A.8090000@plexistor.com>
On Thu, Feb 26, 2015 at 10:41:46AM +0200, Boaz Harrosh wrote:
>
> People systems have been using ramdisk with
> smaller-than-page-size blocks in their mkfs.
>
> The 4K sectors is only important if we will be
> using brd with a DAX filesystem.
>
> So only enable 4K sectors if DAX is configured
4k sectors are not a problem - we should be handling them fine and
because it makes the ramdisk look like a 512e drive, no applications
should fail, either.
The main "unexpected" part about it was how much of xfstests didn't
handle 4k sectors in mkfs output properly. This isn't a problem with
the kernel change and so doesn't need fixing.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-02-27 0:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1424818479-10083-1-git-send-email-david@fromorbit.com>
[not found] ` <1424818479-10083-2-git-send-email-david@fromorbit.com>
[not found] ` <20150225161151.GC28053@bfoster.bfoster>
2015-02-25 22:32 ` ramdisk problems in 4.0-rc1? (was Re: [PATCH 1/4] xfs/104: log size too small for 4k sector drives) Dave Chinner
2015-02-25 23:31 ` Brian Foster
2015-02-25 23:43 ` Dave Chinner
2015-02-26 7:46 ` Boaz Harrosh
2015-02-26 17:23 ` Brian Foster
2015-03-01 8:49 ` Boaz Harrosh
2015-03-01 14:28 ` Brian Foster
2015-02-27 0:58 ` Dave Chinner
2015-03-01 8:27 ` Boaz Harrosh
2015-03-02 1:09 ` Dave Chinner
2015-03-02 9:40 ` Boaz Harrosh
2015-02-26 8:14 ` [PATCH] brd: Re-instate ram disk visibility option (part_show) Boaz Harrosh
2015-02-26 8:41 ` [PATCH] brd: Only request 4K sectors if DAX is enabled Boaz Harrosh
2015-02-26 8:48 ` Boaz Harrosh
2015-02-27 0:23 ` Dave Chinner [this message]
2015-03-01 8:30 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150227002302.GF18360@dastard \
--to=david@fromorbit.com \
--cc=axboe@fb.com \
--cc=bfoster@redhat.com \
--cc=boaz@plexistor.com \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).