linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wanpeng Li <wanpeng.li@linux.intel.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Changman Lee <cm224.lee@samsung.com>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: Re: [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries
Date: Fri, 27 Feb 2015 16:54:45 +0800	[thread overview]
Message-ID: <20150227085445.GA22247@kernel> (raw)
In-Reply-To: <1425026977-20893-1-git-send-email-wanpeng.li@linux.intel.com>

Please ignore this one which w/o patch description.
On Fri, Feb 27, 2015 at 04:49:37PM +0800, Wanpeng Li wrote:
>Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
>---
> fs/f2fs/segment.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>index daee4ab..e7b83b6 100644
>--- a/fs/f2fs/segment.c
>+++ b/fs/f2fs/segment.c
>@@ -1730,6 +1730,9 @@ void flush_sit_entries(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> 	mutex_lock(&curseg->curseg_mutex);
> 	mutex_lock(&sit_i->sentry_lock);
> 
>+	if (!sit_i->dirty_sentries)
>+		goto out;
>+
> 	/*
> 	 * add and account sit entries of dirty bitmap in sit entry
> 	 * set temporarily
>@@ -1744,9 +1747,6 @@ void flush_sit_entries(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> 	if (!__has_cursum_space(sum, sit_i->dirty_sentries, SIT_JOURNAL))
> 		remove_sits_in_journal(sbi);
> 
>-	if (!sit_i->dirty_sentries)
>-		goto out;
>-
> 	/*
> 	 * there are two steps to flush sit entries:
> 	 * #1, flush sit entries to journal in current cold data summary block.
>-- 
>1.9.1

  reply	other threads:[~2015-02-27  8:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27  8:49 [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries Wanpeng Li
2015-02-27  8:54 ` Wanpeng Li [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-02-27  8:52 Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227085445.GA22247@kernel \
    --to=wanpeng.li@linux.intel.com \
    --cc=cm224.lee@samsung.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).