From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 3/6] xfs: add DAX file operations support Date: Thu, 5 Mar 2015 09:03:48 +1100 Message-ID: <20150304220348.GW18360@dastard> References: <1425425427-16283-1-git-send-email-david@fromorbit.com> <1425425427-16283-4-git-send-email-david@fromorbit.com> <54F6D9E4.9050803@gmail.com> <20150304130100.GU18360@dastard> <54F71CBA.2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, willy@linux.intel.com To: Boaz Harrosh Return-path: Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:55830 "EHLO ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbbCDWDv (ORCPT ); Wed, 4 Mar 2015 17:03:51 -0500 Content-Disposition: inline In-Reply-To: <54F71CBA.2@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Mar 04, 2015 at 04:54:50PM +0200, Boaz Harrosh wrote: > On 03/04/2015 03:01 PM, Dave Chinner wrote: > > On Wed, Mar 04, 2015 at 12:09:40PM +0200, Boaz Harrosh wrote: > <> > > > > So, we definitely need splice to/from DAX enabled inodes to be > > rejected. I'll have a look at that... > > > > default_file_splice_read uses kernel_readv which I think might actually > work. Do you know what xfstest(s) exercise splice? We have a rudimentary one only because I discovered a while back none existed at all. i.e. splice is effectively untested by xfstests. If you want to write some tests to execise it, that'd be great.... Cheers, Dave. -- Dave Chinner david@fromorbit.com