From: Tejun Heo <tj@kernel.org>
To: Greg Thelen <gthelen@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Konstantin Khebnikov <khlebnikov@yandex-team.ru>,
Dave Chinner <david@fromorbit.com>,
Sha Zhengju <handai.szj@gmail.com>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-fsdevel@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] memcg: add per cgroup dirty page accounting
Date: Mon, 9 Mar 2015 11:31:16 -0400 [thread overview]
Message-ID: <20150309153116.GV13283@htj.duckdns.org> (raw)
In-Reply-To: <CAHH2K0aFJ1Ti+gWkHM1VC=mdLZQE2Yn+8gpvthOnv89DjmVAAQ@mail.gmail.com>
On Mon, Mar 09, 2015 at 11:29:05AM -0400, Greg Thelen wrote:
> On Mon, Mar 9, 2015 at 9:52 AM, Tejun Heo <tj@kernel.org> wrote:
> > Hello, Greg.
> >
> > On Sun, Mar 08, 2015 at 09:50:32PM -0700, Greg Thelen wrote:
> >> When modifying PG_Dirty on cached file pages, update the new
> >> MEM_CGROUP_STAT_DIRTY counter. This is done in the same places where
> >> global NR_FILE_DIRTY is managed. The new memcg stat is visible in the
> >> per memcg memory.stat cgroupfs file. The most recent past attempt at
> >> this was http://thread.gmane.org/gmane.linux.kernel.cgroups/8632
> >
> > Awesome. I had a similar but inferior (haven't noticed the irqsave
> > problem) patch in my series. Replaced that with this one. I'm
> > getting ready to post the v2 of the cgroup writeback patchset. Do you
> > mind routing this patch together in the patchset?
>
> I don't object to routing this patch with the larger writeback series.
> But I do have small concern that merging the writeback series might
> take a while and this patch has independent value. For now, I'd say:
> go for it. If the series gets stalled we might want to split it off.
Yeah, sure, either is fine for me. Hmm... I'm gonna move this patch
to the head of the series so that it can go either way.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-03-09 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 4:50 [PATCH] memcg: add per cgroup dirty page accounting Greg Thelen
2015-03-09 13:52 ` Tejun Heo
2015-03-09 15:29 ` Greg Thelen
2015-03-09 15:31 ` Tejun Heo [this message]
2015-03-11 16:25 ` Konstantin Khlebnikov
2015-03-11 19:57 ` Greg Thelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309153116.GV13283@htj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=gthelen@google.com \
--cc=handai.szj@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).