Re: [dm-devel] [PATCH 1/3] dm: log writes target

[Vivek Goyal <vgoyal@redhat.com>]

On Thu, Mar 19, 2015 at 04:31:08PM -0400, Josef Bacik wrote:

[..]
> + * We log writes only after they have been flushed, this makes the log describe
> + * close to the order in which the data hits the actual disk, not its cache.  So
> + * for example the following sequence (W means write, C means complete)
> + *
> + * Wa,Wb,Wc,Cc,Ca,FLUSH,FUAd,Cb,CFLUSH,CFUAd
> + *
> + * Would result in the log looking like this
> + *
> + * c,a,flush,fuad,b,<other writes>,<next flush>
> + *

A minor nit, Should this sequence be following.

c,a,b, flush,fuad,<other writes>,<next flush>

when flush completed by that time write of b has completed too. So it
should be written first?

Thanks
Vivek