From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 5/8] xfs: add DAX file operations support Date: Wed, 25 Mar 2015 08:17:40 +1100 Message-ID: <20150324211740.GT28621@dastard> References: <1427194266-2885-1-git-send-email-david@fromorbit.com> <1427194266-2885-6-git-send-email-david@fromorbit.com> <551153C4.6000808@plexistor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, willy@linux.intel.com, jack@suse.cz To: Boaz Harrosh Return-path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:61835 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800AbbCXVRn (ORCPT ); Tue, 24 Mar 2015 17:17:43 -0400 Content-Disposition: inline In-Reply-To: <551153C4.6000808@plexistor.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Mar 24, 2015 at 02:08:36PM +0200, Boaz Harrosh wrote: > On 03/24/2015 12:51 PM, Dave Chinner wrote: > > From: Dave Chinner > > > > Add the initial support for DAX file operations to XFS. This > > includes the necessary block allocation and mmap page fault hooks > > for DAX to function. > > > > Note: we specifically have to disable splice_read/write from > > It looks from below code that splice_read is perfectly supportable > through the call to default_file_splice_read() so you might > want to change the comment here. Ah, I forgot to update the description. > Regarding splice_write: > It looks to me like you left the vector at iter_file_splice_write(). > If I understand correctly I think you need to call default_file_splice_write() > that uses memcpy, just as it was at the previous patches when you left > the vector NULL. So I think you need the same switch for write > as you do below for read. iter_file_splice_write() uses vfs_iter_write, which goes through ->write_iter, which we punt to the direct IO path for DAX. Cheers, Dave. -- Dave Chinner david@fromorbit.com