From: Dave Chinner <david@fromorbit.com>
To: Jens Axboe <axboe@fb.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, ming.l@ssi.samsung.com
Subject: Re: [PATCH 6/6] xfs: add support for buffered writeback stream ID
Date: Wed, 25 Mar 2015 13:41:54 +1100 [thread overview]
Message-ID: <20150325024154.GE31342@dastard> (raw)
In-Reply-To: <1427210823-5283-7-git-send-email-axboe@fb.com>
On Tue, Mar 24, 2015 at 09:27:03AM -0600, Jens Axboe wrote:
> Signed-off-by: Jens Axboe <axboe@fb.com>
> ---
> fs/xfs/xfs_aops.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 3a9b7a1b8704..2b00a57732e3 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -377,6 +377,7 @@ xfs_submit_ioend_bio(
> atomic_inc(&ioend->io_remaining);
> bio->bi_private = ioend;
> bio->bi_end_io = xfs_end_bio;
> + bio_set_streamid(bio, wbc->streamid);
> submit_bio(wbc->sync_mode == WB_SYNC_ALL ? WRITE_SYNC : WRITE, bio);
Like I said, this is wrong.
+ bio_set_streamid(bio, ioend->io_inode->i_streamid);
is actually what it should be.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-03-25 2:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 15:26 [PATCH RFC] Support for write stream IDs Jens Axboe
2015-03-24 15:26 ` [PATCH 1/6] block: add support for carrying a stream ID in a bio Jens Axboe
2015-03-24 17:11 ` Matias Bjørling
2015-03-24 17:26 ` Jens Axboe
2015-03-24 22:07 ` Ming Lin-SSI
2015-03-25 1:42 ` Jens Axboe
2015-03-25 8:11 ` Matias Bjørling
2015-03-25 18:36 ` Ming Lin-SSI
2015-03-25 2:30 ` Dave Chinner
2015-04-12 10:42 ` Dmitry Monakhov
2015-03-24 15:26 ` [PATCH 2/6] Add support for per-file stream ID Jens Axboe
2015-03-24 15:27 ` [PATCH 3/6] direct-io: add support for write stream IDs Jens Axboe
2015-03-25 2:43 ` Dave Chinner
2015-03-25 14:26 ` Jens Axboe
2015-04-10 23:50 ` Ming Lin
2015-04-11 0:06 ` Ming Lin
2015-04-11 11:59 ` Dave Chinner
2015-04-17 6:20 ` Ming Lin
2015-04-17 23:06 ` Dave Chinner
2015-04-17 23:11 ` Jens Axboe
2015-04-17 23:51 ` Dave Chinner
2015-04-18 2:00 ` Jens Axboe
2015-04-17 15:17 ` Jens Axboe
2015-03-24 15:27 ` [PATCH 4/6] Add stream ID support for buffered writeback Jens Axboe
2015-03-25 2:40 ` Dave Chinner
2015-03-25 14:17 ` Jens Axboe
2015-03-24 15:27 ` [PATCH 5/6] btrfs: add support for buffered writeback stream ID Jens Axboe
2015-03-24 15:27 ` [PATCH 6/6] xfs: " Jens Axboe
2015-03-25 2:41 ` Dave Chinner [this message]
2015-03-24 17:03 ` [PATCH RFC] Support for write stream IDs Jeff Moyer
2015-03-24 17:08 ` Jens Axboe
2015-03-24 21:46 ` Ming Lin-SSI
2015-03-24 21:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325024154.GE31342@dastard \
--to=david@fromorbit.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.l@ssi.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).