From: Christoph Hellwig <hch@lst.de>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org, boaz@plexistor.com,
axboe@kernel.dk
Subject: Re: [PATCH 1/3] pmem: Initial version of persistent memory driver
Date: Thu, 26 Mar 2015 09:06:56 +0100 [thread overview]
Message-ID: <20150326080656.GE26540@lst.de> (raw)
In-Reply-To: <1427314913.14654.1.camel@theros.lm.intel.com>
On Wed, Mar 25, 2015 at 02:21:53PM -0600, Ross Zwisler wrote:
> What needed to be fixed with the partition support? I used to have real
> numbers for first_minor and passed into alloc_disk(), but simplified it based
> on code found in this commit in the nvme driver:
>
> 469071a37afc NVMe: Dynamically allocate partition numbers
>
> This has worked fine for me - is there some test case in which it breaks?
Yes, if CONFIG_DEBUG_BLOCK_EXT_DEVT isn't set that code doesn't work at all.
> > +out_unmap:
> > + pmem_unmapmem(pmem);
> > +out_free_dev:
> > + kfree(pmem);
> > +out:
>
> This label is no longer used, and can be removed.
Ok, fixed.
next prev parent reply other threads:[~2015-03-26 8:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 16:04 another pmem variant Christoph Hellwig
2015-03-25 16:04 ` [PATCH 1/3] pmem: Initial version of persistent memory driver Christoph Hellwig
2015-03-25 20:19 ` Paul Bolle
2015-03-25 20:26 ` Ross Zwisler
2015-03-26 8:04 ` Christoph Hellwig
2015-03-25 20:21 ` Ross Zwisler
2015-03-26 8:06 ` Christoph Hellwig [this message]
2015-05-04 16:43 ` Ross Zwisler
2015-05-07 7:26 ` Christoph Hellwig
2015-05-07 8:35 ` Boaz Harrosh
2015-03-25 16:04 ` [PATCH 2/3] x86: add a is_e820_ram() helper Christoph Hellwig
2015-03-26 2:15 ` [Linux-nvdimm] " Dan Williams
2015-03-26 8:01 ` Christoph Hellwig
2015-03-26 13:57 ` Dan Williams
2015-03-26 14:32 ` Christoph Hellwig
2015-03-25 16:04 ` [PATCH 3/3] x86: add support for the non-standard protected e820 type Christoph Hellwig
2015-03-25 19:47 ` Elliott, Robert (Server Storage)
2015-03-26 8:02 ` Christoph Hellwig
2015-03-25 20:23 ` Ross Zwisler
2015-03-25 20:29 ` [Linux-nvdimm] " Dan Williams
2015-03-25 20:25 ` Ross Zwisler
2015-03-26 8:03 ` Christoph Hellwig
2015-03-25 20:35 ` [Linux-nvdimm] " Dan Williams
2015-03-25 16:33 ` [Linux-nvdimm] another pmem variant Dan Williams
2015-03-25 16:44 ` Christoph Hellwig
2015-03-25 17:00 ` Dan Williams
2015-03-25 17:04 ` Christoph Hellwig
2015-03-25 17:18 ` Dan Williams
2015-04-13 9:01 ` Greg KH
2015-04-13 16:02 ` Dan Williams
2015-03-25 18:09 ` Brooks, Adam J
2015-03-25 18:46 ` Christoph Hellwig
2015-03-25 21:02 ` Ross Zwisler
-- strict thread matches above, loose matches on Subject: below --
2015-03-26 8:32 another pmem variant V2 Christoph Hellwig
2015-03-26 8:32 ` [PATCH 1/3] pmem: Initial version of persistent memory driver Christoph Hellwig
2015-04-08 18:33 Dr. Greg Wettstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326080656.GE26540@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=boaz@plexistor.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).