From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix
Date: Fri, 27 Mar 2015 13:14:48 +0100
Message-ID: <20150327121448.GB15631@gmail.com>
References: <20150326190800.GF27751@pd.tnic>
 <1427456301-3764-1-git-send-email-hecmargi@upv.es>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Borislav Petkov <bp@alien8.de>, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Jan-Simon <dl9pf@gmx.de>, linux-fsdevel@vger.kernel.org,
	kees Cook <keescook@chromium.org>,
	Ismael Ripoll <iripoll@disca.upv.es>
To: Hector Marco-Gisbert <hecmargi@upv.es>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1427456301-3764-1-git-send-email-hecmargi@upv.es>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org


* Hector Marco-Gisbert <hecmargi@upv.es> wrote:

> A bug in Linux ASLR implementation which affects some AMD processors 
> has been found. The issue affects to all Linux process even if they 
> are not using shared libraries (statically compiled).

It's not a bug, it's a feature: to work around a Bulldozer cache 
aliasing performance problem we have to keep bits 12,13,14 equal for 
all mappings in the system.

Your patch improves upon that fix: by per-boot randomizing the 
constant portion of the randomized range.

Btw., does anyone know how relevant the performance fix is these days? 
A simpler improvement would be to remove the workaround altogether and 
recover proper randomization of bits 12,13,14.

Thanks,

	Ingo