From: Greg KH <gregkh@linuxfoundation.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Jeff Layton <jlayton@poochiereds.net>,
trond.myklebust@primarydata.com, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] sunrpc: make debugfs file creation failure non-fatal
Date: Tue, 31 Mar 2015 16:26:41 +0200 [thread overview]
Message-ID: <20150331142641.GA9961@kroah.com> (raw)
In-Reply-To: <20150331140916.GJ6901@fieldses.org>
On Tue, Mar 31, 2015 at 10:09:16AM -0400, J. Bruce Fields wrote:
> On Mon, Mar 30, 2015 at 07:47:53PM -0400, J. Bruce Fields wrote:
> > ACK.--b.
>
> But note the result after this is that the debugfs directories will
> always miss gss-proxy clients on selinux-enforcing systems. That could
> be really confusing.
So, you shouldn't be relying on debugfs :)
> So we should still fix debugfs's permission checking. It doesn't make
> sense to me as is.
I don't really understand what the problem is here. Is selinux
preventing some debugfs files to be created? If so, great, it's allowed
to do that, go fix up your selinux config files to not do that.
Otherwise, to go around selinux/LSM seems like a bad idea for debugfs to
be doing, don't you think?
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-31 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 21:58 [PATCH] sunrpc: make debugfs file creation failure non-fatal Jeff Layton
[not found] ` <1427752698-32431-1-git-send-email-jeff.layton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2015-03-30 23:47 ` J. Bruce Fields
2015-03-31 14:09 ` J. Bruce Fields
2015-03-31 14:26 ` Greg KH [this message]
2015-03-31 15:11 ` Jeff Layton
2015-03-31 15:48 ` Boaz Harrosh
2015-03-31 15:58 ` J. Bruce Fields
2015-03-31 15:30 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331142641.GA9961@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).