From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/2] pmem: add a driver for persistent memory Date: Thu, 2 Apr 2015 11:32:28 +0200 Message-ID: <20150402093228.GB14209@lst.de> References: <1427872339-6688-1-git-send-email-hch@lst.de> <1427872339-6688-3-git-send-email-hch@lst.de> <551C0C5E.9080003@plexistor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, axboe@kernel.dk, ross.zwisler@linux.intel.com To: Boaz Harrosh Return-path: Content-Disposition: inline In-Reply-To: <551C0C5E.9080003@plexistor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Apr 01, 2015 at 06:18:54PM +0300, Boaz Harrosh wrote: > You might as well rw & WRITE also for the above pmem_do_bvec call. > If there can be such problem than the rw == READ inside > pmem_do_bvec will fail as well. Might be worth to pass a bool to pmem_do_bvec, but we're getting into serious bikeshed territory here..