From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@kernel.org>
Subject: Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard
 protected e820 type
Date: Sat, 4 Apr 2015 11:40:54 +0200
Message-ID: <20150404094054.GA21027@gmail.com>
References: <1427872339-6688-1-git-send-email-hch@lst.de>
 <1427872339-6688-2-git-send-email-hch@lst.de>
 <1428077687.31093.120.camel@misato.fc.hp.com>
 <CAE9FiQXg0DZ3oCGmPk+qubwQ_=9LLMrZTJqN6HPn0t+5Vs8+Jg@mail.gmail.com>
 <1428094444.31093.122.camel@misato.fc.hp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Yinghai Lu <yinghai@kernel.org>, Christoph Hellwig <hch@lst.de>,
	linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Jens Axboe <axboe@kernel.dk>
To: Toshi Kani <toshi.kani@hp.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1428094444.31093.122.camel@misato.fc.hp.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org


* Toshi Kani <toshi.kani@hp.com> wrote:

> On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote:
> > On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani <toshi.kani@hp.com> wrote:
> > > On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote:
> > >   :
> > >> @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align)
> > >>  /*
> > >>   * Find the highest page frame number we have available
> > >>   */
> > >> -static unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned type)
> > >> +static unsigned long __init e820_end_pfn(unsigned long limit_pfn)
> > >>  {
> > >>       int i;
> > >>       unsigned long last_pfn = 0;
> > >> @@ -759,7 +769,11 @@ static unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned type)
> > >>               unsigned long start_pfn;
> > >>               unsigned long end_pfn;
> > >>
> > >> -             if (ei->type != type)
> > >> +             /*
> > >> +              * Persistent memory is accounted as ram for purposes of
> > >> +              * establishing max_pfn and mem_map.
> > >> +              */
> > >> +             if (ei->type != E820_RAM && ei->type != E820_PRAM)
> > >>                       continue;
> > >
> > > Should we also delete this code, accounting E820_PRAM as ram, along with
> > > the deletion of reserve_pmem() in this version?
> > 
> > should revert those end_of_ram change as attached.
> 
> I confirmed that the pmem driver works with the change, and last_pfn is
> updated as expected.

Could someone please send the fix with a changelog, etc?

Thanks,

	Ingo