From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 02/16] vfs: check kiocb->ki_flags instead filp->fl_flags Date: Sat, 4 Apr 2015 22:36:22 +0100 Message-ID: <20150404213621.GH889@ZenIV.linux.org.uk> References: <1428174805-853-1-git-send-email-dmonakhov@openvz.org> <1428174805-853-3-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Dmitry Monakhov Return-path: Content-Disposition: inline In-Reply-To: <1428174805-853-3-git-send-email-dmonakhov@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Apr 04, 2015 at 11:13:11PM +0400, Dmitry Monakhov wrote: > generic_write_checks now accept kiocb as an argument > Unfortunetly it is impossible to get rid of old interface because some crappy > do not support write_iter interface so leave __generic_write_checks as backward > compatibility helper. Check the current vfs.git#for-next (there's even some generic_write_checks() work in it). The same goes for the rest of the series. Please, rebase it. What's more, generic_write_checks() should take iov_iter *, not the address of something its ->count had been copied into. Note that all callers of that thing end up doing iov_iter_truncate() pretty soon afterwards. I hadn't pushed that one out yet (there is some weirdness in ocfs2 which might be a bug; I want to sort that out first), but that's where it's going.