From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and
	unload
Date: Tue, 7 Apr 2015 17:19:15 +0200
Message-ID: <20150407151915.GA18426@lst.de>
References: <1427872339-6688-1-git-send-email-hch@lst.de> <551D60BE.1070101@plexistor.com> <CAPcyv4gRONdKn7bi2gS7RWWrNT=YuAPk-wNtJy_n_BTQq--LVw@mail.gmail.com> <551D6488.9090501@plexistor.com> <CAPcyv4isuVk36ZihTRg1jhiWnXhJvSdD3b_tesxc-srTHD9h9w@mail.gmail.com> <20150402164431.GB9774@lst.de> <5520F73E.3020602@plexistor.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-nvdimm <linux-nvdimm@ml01.01.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Ingo Molnar <mingo@redhat.com>
To: Boaz Harrosh <boaz@plexistor.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <5520F73E.3020602@plexistor.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Sun, Apr 05, 2015 at 11:50:06AM +0300, Boaz Harrosh wrote:
> [  +0.000537] pmem: init 2 devices => 0
> 
> So I have all the information. And I know the driver was actually loaded
> successfully on the expected two regions.

The second number will always be 0, so no point in printing it.
Also device can be hotplugged at runtime, e.g. your magic PCIe device,
so iff you really want to print anything ->probe is the place for it.

But I still don't think we need it, once booted you can trivially look
up the information in sysfs.