From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: I_CLEAR bug while shrinking dcache Date: Tue, 14 Apr 2015 16:44:02 +0200 Message-ID: <20150414144402.GN3107@type.bordeaux.inria.fr> References: <20150414081254.GD14691@type.youpi.perso.aquilenet.fr> <20150414124428.GW889@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Al Viro Return-path: Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:34429 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932439AbbDNOoE (ORCPT ); Tue, 14 Apr 2015 10:44:04 -0400 Content-Disposition: inline In-Reply-To: <20150414124428.GW889@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Al Viro, le Tue 14 Apr 2015 13:44:29 +0100, a =E9crit : > On Tue, Apr 14, 2015 at 10:12:54AM +0200, Samuel Thibault wrote: > > So it seems that shrink_dentry_list was trying to kill an inode whi= ch > > already has I_CLEAR. I'll be trying the attached patch in the next > > days. >=20 > That patch is just papering over the problem. I never said it was a proper fix :) > The first variant can happen, but in that case it should have had > DCACHE_DENTRY_KILLED set by said __dentry_kill() and skipped. The ot= her > two are clear inode refcounting bugs. >=20 > Do you have a reproducer for that? It just happened in the middle of the night. Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html