From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
Zach Brown <zab@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
linux-btrfs@vger.kernel.org,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper
Date: Tue, 14 Apr 2015 09:58:03 -0700 [thread overview]
Message-ID: <20150414165803.GA4739@infradead.org> (raw)
In-Reply-To: <20150414165344.GA21421@infradead.org>
On Tue, Apr 14, 2015 at 09:53:44AM -0700, Christoph Hellwig wrote:
> On Sat, Apr 11, 2015 at 09:04:02AM -0400, Jeff Layton wrote:
> > Yuck! How the heck do you clean up the mess if that happens? I guess
> > you're just stuck redoing the copy with normal READ/WRITE?
> >
> > Maybe we need to have the interface return a hard error in that
> > case and not try to give back any sort of offset?
>
> The NFSv4.2 COPY interface is a train wreck. At least for Linux I'd
> expect us to simply ignore it and only implement my new CLONE operation
> with sane semantics. That is unless someone can show some real life
> use case for the inter server copy, in which case we'll have to deal
> with that mess. But getting that one right at the VFS level will
> be a nightmare anyway.
Btw, in case someone cares about the NFS CLONE implementation here is
my prototype based on Anna's older COPY prototype. It's simple enough that
it might be worth adding to the copy_file_range patch set.
http://git.infradead.org/users/hch/pnfs.git/shortlog/refs/heads/clone
next prev parent reply other threads:[~2015-04-14 16:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 22:00 [PATCH RFC 0/3] simple copy offloading system call Zach Brown
2015-04-10 22:00 ` [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper Zach Brown
[not found] ` <1428703236-24735-2-git-send-email-zab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-10 22:36 ` Trond Myklebust
2015-04-11 0:02 ` Zach Brown
2015-04-11 0:24 ` Trond Myklebust
2015-04-11 13:04 ` Jeff Layton
2015-04-13 16:32 ` Zach Brown
2015-04-14 16:53 ` Christoph Hellwig
2015-04-14 16:58 ` Christoph Hellwig [this message]
[not found] ` <20150414165344.GA21421-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-04-14 17:16 ` Anna Schumaker
[not found] ` <552D4B5D.3090904-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2015-04-14 18:19 ` J. Bruce Fields
[not found] ` <20150414181911.GA2080-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-04-14 18:22 ` Zach Brown
[not found] ` <20150414182241.GB23129-fypN+1c5dIyjpB87vu3CluTW4wlIGRCZ@public.gmane.org>
2015-04-14 18:29 ` J. Bruce Fields
[not found] ` <20150414182906.GB2080-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-04-14 18:54 ` Zach Brown
[not found] ` <20150414185408.GC23129-fypN+1c5dIyjpB87vu3CluTW4wlIGRCZ@public.gmane.org>
2015-04-14 19:23 ` Christoph Hellwig
[not found] ` <20150414192325.GB20599-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-04-14 20:04 ` Zach Brown
2015-04-10 23:01 ` Andreas Dilger
2015-04-10 22:00 ` [PATCH RFC 2/3] x86: add sys_copy_file_range to syscall tables Zach Brown
2015-04-10 22:00 ` [PATCH RFC 3/3] btrfs: add .copy_file_range file operation Zach Brown
2015-04-14 17:08 ` Chris Mason
[not found] ` <1428703236-24735-1-git-send-email-zab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-06 6:15 ` [PATCH RFC 0/3] simple copy offloading system call Michael Kerrisk
2015-05-07 2:52 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414165803.GA4739@infradead.org \
--to=hch@infradead.org \
--cc=jlayton@poochiereds.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).