From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/3] direct-io: only inc/dec inode->i_dio_count for file
 systems
Date: Thu, 16 Apr 2015 00:30:51 +0100
Message-ID: <20150415233051.GT889@ZenIV.linux.org.uk>
References: <1429135298-17153-1-git-send-email-axboe@fb.com>
 <1429135298-17153-2-git-send-email-axboe@fb.com>
 <20150415223620.GU13731@dastard>
 <20150415225625.GR889@ZenIV.linux.org.uk>
 <552EEECC.90008@fb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Dave Chinner <david@fromorbit.com>, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>,
	"Elliott, Robert (Server Storage)" <elliott@hp.com>
To: Jens Axboe <axboe@fb.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:36039 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756210AbbDOXaz (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 15 Apr 2015 19:30:55 -0400
Content-Disposition: inline
In-Reply-To: <552EEECC.90008@fb.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Apr 15, 2015 at 05:05:48PM -0600, Jens Axboe wrote:
> On 04/15/2015 04:56 PM, Al Viro wrote:
> >On Thu, Apr 16, 2015 at 08:36:20AM +1000, Dave Chinner wrote:
> >
> >>Bikeshedding: I think this would be better suited to inode_dio_begin()
> >>and inode_dio_end() because now we are trying to say "this is where
> >>the DIO starts, and this is where it ends". It's not really
> >>"reference counting" interface, we're trying to annotate the
> >>boundaries of where DIO iis protected against truncate....
> >
> >*nod*
> >
> >And while we are at, inode_dio_begin() could be static inline just fine.
> 
> Done (rename and docbook), and inode_dio_{begin.end}() made static inlines.
> 
> v3 against vfs-next attached.

Applied.