From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/3] fscache/cachefiles: optionally use SEEK_DATA instead of ->bmap. Date: Sun, 19 Apr 2015 23:08:18 -0700 Message-ID: <20150420060818.GA32675@infradead.org> References: <20150420052558.26554.97143.stgit@notabene.brown> <20150420052752.26554.52672.stgit@notabene.brown> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Howells , Chris Mason , Al Viro , Josef Bacik , David Sterba , linux-cachefs@vger.kernel.org, Dave Chinner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org To: NeilBrown Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:45157 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753658AbbDTGIW (ORCPT ); Mon, 20 Apr 2015 02:08:22 -0400 Content-Disposition: inline In-Reply-To: <20150420052752.26554.52672.stgit@notabene.brown> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Please just usse SEEK_HOLE/DATA support unconditioanlly. ->bmap is a horrible hack that is completely unsafe.