From: Jan Kara <jack@suse.cz>
To: Jens Axboe <axboe@fb.com>
Cc: linux-fsdevel@vger.kernel.org, elliott@hp.com
Subject: Re: [PATCH] bio: skip atomic inc/dec of ->bi_remaining for non-chains
Date: Mon, 20 Apr 2015 18:04:46 +0200 [thread overview]
Message-ID: <20150420160446.GL17020@quack.suse.cz> (raw)
In-Reply-To: <20150417145933.GA4770@kernel.dk>
On Fri 17-04-15 08:59:33, Jens Axboe wrote:
> @@ -292,8 +292,8 @@ void bio_reset(struct bio *bio)
> __bio_free(bio);
>
> memset(bio, 0, BIO_RESET_BYTES);
> - bio->bi_flags = flags|(1 << BIO_UPTODATE);
> - atomic_set(&bio->bi_remaining, 1);
> + bio->bi_flags = flags | 1 << BIO_UPTODATE;
Although this is correct, I'd prefer to keep parenthesis around 1 <<
BIO_UPTODATE. Maybe I'm not a real C hacker but I had to lookup the
operator precedence of | vs << :).
Otherwise the patch looks good to me (but I'm not an expert in this area, I
just looked into the patch by accident because I thought it's another
respin of your direct IO patch ;).
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2015-04-20 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 14:59 [PATCH] bio: skip atomic inc/dec of ->bi_remaining for non-chains Jens Axboe
2015-04-20 16:04 ` Jan Kara [this message]
2015-04-20 16:42 ` Jens Axboe
2015-04-21 9:04 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420160446.GL17020@quack.suse.cz \
--to=jack@suse.cz \
--cc=axboe@fb.com \
--cc=elliott@hp.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).