From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 01/24] lustre: rip the private symlink nesting limit out Date: Mon, 20 Apr 2015 21:35:44 +0100 Message-ID: <20150420203544.GM889@ZenIV.linux.org.uk> References: <20150420181222.GK889@ZenIV.linux.org.uk> <1429553588-24764-1-git-send-email-viro@ZenIV.linux.org.uk> <343FC7D4-20A1-45D7-B86F-1BD2DC21F53A@dilger.ca> <20150420192253.GL889@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Oleg Drokin , Neil Brown , LKML , Linux Filesystem Mailing List To: Andreas Dilger Return-path: Content-Disposition: inline In-Reply-To: <20150420192253.GL889@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Apr 20, 2015 at 08:22:53PM +0100, Al Viro wrote: > On Mon, Apr 20, 2015 at 01:08:16PM -0600, Andreas Dilger wrote: > > On Apr 20, 2015, at 12:12 PM, Al Viro wrote: > > > > > > From: Al Viro > > > > > > Signed-off-by: Al Viro > > > > Al, the patch itself looks good, thanks. > > > > However, if this is applied at the start of the series it could > > allow tests to easily cause a stack overflow during a bisection (I > > don't think users would see a kernel in the middle of the series). > > > > Could this be converted over to checking nd->link_count along with > > the [02/24] patch until closer to the end of the series when the > > recursion has been removed? > > Er... You do realize that struct nameidata is opaque for anything outside > of fs/namei.c and has been that way for a while now? Sure, we can export > a helper that would return that and rip it out in the end of the series, > but... Actually, a cleaner solution would be to reorder that bunch (1--6) past the link_path_walk() reorganization. Done and force-pushed to the same branch...