From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: Is it OK to export symbols 'getname' and 'putname'? Date: Tue, 21 Apr 2015 22:50:15 -0700 Message-ID: <20150422055015.GA3731@infradead.org> References: <1427309152-25129-1-git-send-email-boqun.feng@gmail.com> <20150329042744.GA1477@fixme-laptop> <20150407083826.GA1048@fixme-laptop.cn.ibm.com> <20150411235655.GK889@ZenIV.linux.org.uk> <20150412011318.GL889@ZenIV.linux.org.uk> <20150417123530.GA4249@fixme-laptop.cn.ibm.com> <20150420155507.GK17020@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Boqun Feng , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20150420155507.GK17020@quack.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote: > > Is that a good idea to export these symbols, given that lustre may be > > the only user? > Yes, it is a good idea. It was if lustre was in core code and these idiotic ioctls were something we had to live with. But lustre is in staging code, and we shouldn't export symbols just for shitty staging code. Intead lustre should clean up their mess and get rid of these ioctls that do path name lookups.