From: Boqun Feng <boqun.feng@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>, Boqun Feng <boqun.feng@gmail.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Is it OK to export symbols 'getname' and 'putname'?
Date: Thu, 23 Apr 2015 13:32:00 +0800 [thread overview]
Message-ID: <20150423053200.GA3585@fixme-laptop.cn.ibm.com> (raw)
In-Reply-To: <20150422055015.GA3731@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On Tue, Apr 21, 2015 at 10:50:15PM -0700, Christoph Hellwig wrote:
> On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote:
> > > Is that a good idea to export these symbols, given that lustre may be
> > > the only user?
> > Yes, it is a good idea.
>
> It was if lustre was in core code and these idiotic ioctls were something
> we had to live with.
>
> But lustre is in staging code, and we shouldn't export symbols just for
> shitty staging code.
>
> Intead lustre should clean up their mess and get rid of these ioctls
> that do path name lookups.
OK, good point. Thank you!
Regards,
Boqun Feng
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-23 5:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 18:45 [PATCH v2] vfs: avoid recopying file names in getname_flags Boqun Feng
2015-03-29 4:27 ` Boqun Feng
2015-03-29 10:14 ` Richard Weinberger
2015-03-29 15:23 ` Boqun Feng
2015-04-07 8:38 ` Boqun Feng
2015-04-11 23:56 ` Al Viro
2015-04-12 1:13 ` Al Viro
2015-04-13 7:34 ` Boqun Feng
2015-04-17 12:35 ` Is it OK to export symbols 'getname' and 'putname'? Boqun Feng
2015-04-18 0:20 ` Boqun Feng
2015-04-20 15:55 ` Jan Kara
2015-04-22 2:38 ` Boqun Feng
2015-04-22 5:50 ` Christoph Hellwig
2015-04-23 5:32 ` Boqun Feng [this message]
2015-04-13 6:33 ` [PATCH v2] vfs: avoid recopying file names in getname_flags Boqun Feng
2015-03-29 10:13 ` Richard Weinberger
2015-03-29 15:10 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423053200.GA3585@fixme-laptop.cn.ibm.com \
--to=boqun.feng@linux.vnet.ibm.com \
--cc=boqun.feng@gmail.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).