From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] fs/compat: remove redundant 'less than zero' check
Date: Fri, 24 Apr 2015 15:04:53 +0300
Message-ID: <20150424120453.GO14154@mwanda>
References: <1429870070-30310-1-git-send-email-firogm@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: viro@zeniv.linux.org.uk, kernel-janitors@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
To: Firo Yang <firogm@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from userp1040.oracle.com ([156.151.31.81]:47798 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752510AbbDXMFB (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 24 Apr 2015 08:05:01 -0400
Content-Disposition: inline
In-Reply-To: <1429870070-30310-1-git-send-email-firogm@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Apr 24, 2015 at 06:07:50PM +0800, Firo Yang wrote:

> -	if (nr_segs > UIO_MAXIOV || nr_segs < 0)
> +	if (nr_segs > UIO_MAXIOV)

Linus said at kernel summit that he thinks this kind of checks are ok.

Smatch already ignores checks like:

	if (nr_segs < 0 || nr_segs > UIO_MAXIOV)

So making it ignore this one as well shouldn't be hard...  I'll change
Smatch to ignore this one as well.

regards,
dan carpenter