From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache
Date: Sat, 25 Apr 2015 22:05:20 +0100 [thread overview]
Message-ID: <20150425210520.GG889@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150425183247.GA30562@lst.de>
On Sat, Apr 25, 2015 at 08:32:47PM +0200, Christoph Hellwig wrote:
> On Sat, Apr 25, 2015 at 03:57:28PM +0100, Al Viro wrote:
> > > Note that caching the symlink in a kmalloc'ed buffer might be
> > > more efficient than the pagecache for most cases anyway.
> >
> > Hmm... When would you free the sucker?
>
> final iput. Similar design to the generic ACL cache.
Except that in this case you have to deal with the cases when it should
_not_ be freed in ->evict_inode() (and doing that in generic code is
right out). I'm not sure it will be simpler that way, actually...
prev parent reply other threads:[~2015-04-25 21:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1429816064-10033-1-git-send-email-hch@lst.de>
[not found] ` <1429816064-10033-6-git-send-email-hch@lst.de>
[not found] ` <20150423222942.GK15810@dastard>
2015-04-25 14:16 ` [PATCH 5/6] xfs: move non-inline symlinks to the pagecache Christoph Hellwig
2015-04-25 14:57 ` Al Viro
2015-04-25 15:11 ` Al Viro
2015-04-25 18:32 ` Christoph Hellwig
2015-04-25 21:05 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150425210520.GG889@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).