From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache
Date: Sat, 25 Apr 2015 22:05:20 +0100
Message-ID: <20150425210520.GG889@ZenIV.linux.org.uk>
References: <1429816064-10033-1-git-send-email-hch@lst.de>
 <1429816064-10033-6-git-send-email-hch@lst.de>
 <20150423222942.GK15810@dastard>
 <20150425141612.GA4153@lst.de>
 <20150425145728.GE889@ZenIV.linux.org.uk>
 <20150425183247.GA30562@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com,
	linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:60471 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750749AbbDYVFX (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 25 Apr 2015 17:05:23 -0400
Content-Disposition: inline
In-Reply-To: <20150425183247.GA30562@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Apr 25, 2015 at 08:32:47PM +0200, Christoph Hellwig wrote:
> On Sat, Apr 25, 2015 at 03:57:28PM +0100, Al Viro wrote:
> > > Note that caching the symlink in a kmalloc'ed buffer might be
> > > more efficient than the pagecache for most cases anyway.
> > 
> > Hmm...  When would you free the sucker?
> 
> final iput.  Similar design to the generic ACL cache.

Except that in this case you have to deal with the cases when it should
_not_ be freed in ->evict_inode() (and doing that in generic code is
right out).  I'm not sure it will be simpler that way, actually...