From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2] Support for write stream IDs Date: Tue, 5 May 2015 13:43:19 -0700 Message-ID: <20150505204319.GA5513@infradead.org> References: <1430856181-19568-1-git-send-email-axboe@fb.com> <20150505200757.GA23902@infradead.org> <55492411.1010806@fb.com> <20150505202045.GA25695@infradead.org> <554928A6.6030603@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, adilger@dilger.ca, david@fromorbit.com To: Jens Axboe Return-path: Content-Disposition: inline In-Reply-To: <554928A6.6030603@fb.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, May 05, 2015 at 02:31:34PM -0600, Jens Axboe wrote: > Even outside of that, there are use cases for caching that need not have > hardware assist. Could, would. But in the meantime you'd adding dead wood kernel code, and even worse user interfaces. > >Merging infrastructure without any users is a > >bad idea in general, and merging infrastructure with no user that > >exposes untestable user interface and bloats core data structures is > >even worse. I don't think this has any merit at all at this point. > > There is a user, we are using it. And there's no data structure bloating, > both the file and inode additions are filling existing holes. I'll strongly > disagree with your statement that it has no merit at all. In fact, the merit > is quite clear. Make sure everyone an get a nvme card from samsung supproting their hack, and add it to the nvme driver keyed of a PCI ID check and we can start talking about it. We're not going to add hacks only a specific big corporation can use. Btw, the user interfacess really need man page additions and go past linux-man and linux-api even in that case.