From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3 2/7] block: add REQ_NVM_GC for targets gc Date: Sat, 9 May 2015 09:00:26 -0700 Message-ID: <20150509160026.GB16058@infradead.org> References: <1429712816-10336-1-git-send-email-m@bjorling.me> <1429712816-10336-3-git-send-email-m@bjorling.me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, keith.busch@intel.com, javier@paletta.io To: Matias Bj??rling Return-path: Content-Disposition: inline In-Reply-To: <1429712816-10336-3-git-send-email-m@bjorling.me> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Apr 22, 2015 at 04:26:51PM +0200, Matias Bj??rling wrote: > In preparation for Open-Channel SSDs. We introduce a special request for > open-channel ssd targets that must perform garbage collection. > > Requests are divided into two types. The user and target specific. User > IOs are from fs, user-space, etc. While target specific are IOs that are > issued in the background by targets. Usually garbage collection actions. > > For the target to issue garbage collection requests, it is a requirement > that a logical address is locked over two requests. One read and one > write. If a write to the logical address comes in from user-space, a > race-condition might occur and garbage collection will write out-dated > data. > > By introducing this flag, the target can manually control locking of > logical addresses. Seems like this should be a new ->cmd_type instead of a flag.