From: Omar Sandoval <osandov@osandov.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Ivan Delalande <colona@arista.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: Fix, simpliy and stop using d_dname for the /proc/*/ns/* files.
Date: Wed, 20 May 2015 16:00:45 -0700 [thread overview]
Message-ID: <20150520230045.GA4015@mew.dhcp4.washington.edu> (raw)
In-Reply-To: <87bnhedhw5.fsf_-_@x220.int.ebiederm.org>
On Wed, May 20, 2015 at 05:05:30PM -0500, Eric W. Biederman wrote:
> This works for me, can you confirm it works for you folks as well?
>
> Thank you,
> Eric
Yup, neither reproducer produces the warning anymore.
Reported-and-Tested-by: Omar Sandoval <osandov@osandov.com>
> From: "Eric W. Biederman" <ebiederm@xmission.com>
> Date: Wed, 20 May 2015 16:39:00 -0500
> Subject: [PATCH] vfs: Fix, simpliy and stop using d_dname for the /proc/*/ns/* files.
>
> Now that these files are no longer in proc we can stop playing games
> with d_alloc_pseudo and d_dname. This change causes a couple of user
> visible changes:
>
> - Opening /proc/*/ns/* and then readlink on /proc/self/fd/N now sees a
> prepended / in the filename.
>
> - /proc/mountinfo now gives useful information on what is mounted.
>
> - Bind mounting /proc/*/ns/*, opening the mounted file, removing the
> bind mount, and readlink on /proc/self/fd/N now sees / (as it should)
What's the rationale for "/" in this case? (I'm not disagreeing, just
looking to learn something.)
Thanks,
--
Omar
next prev parent reply other threads:[~2015-05-20 23:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 18:58 Warning: empty root dentry name after lazy mount removal Ivan Delalande
2015-05-20 10:05 ` Omar Sandoval
2015-05-20 22:05 ` [PATCH] vfs: Fix, simpliy and stop using d_dname for the /proc/*/ns/* files Eric W. Biederman
2015-05-20 23:00 ` Omar Sandoval [this message]
2015-05-20 23:08 ` Ivan Delalande
2015-05-20 23:23 ` Al Viro
2015-06-03 20:51 ` Ivan Delalande
2015-06-06 19:27 ` Eric W. Biederman
2015-06-06 19:30 ` [PATCH] vfs: Remove incorrect debugging WARN in prepend_path Eric W. Biederman
2015-06-06 20:08 ` [PATCH] vfs: Fix, simpliy and stop using d_dname for the /proc/*/ns/* files Ivan Delalande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520230045.GA4015@mew.dhcp4.washington.edu \
--to=osandov@osandov.com \
--cc=colona@arista.com \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).