From mboxrd@z Thu Jan 1 00:00:00 1970 From: Omar Sandoval Subject: Re: [PATCH] vfs: Fix, simpliy and stop using d_dname for the /proc/*/ns/* files. Date: Wed, 20 May 2015 16:00:45 -0700 Message-ID: <20150520230045.GA4015@mew.dhcp4.washington.edu> References: <20150515185820.GQ20468@ycc.fr> <20150520100557.GB32189@mew> <87bnhedhw5.fsf_-_@x220.int.ebiederm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ivan Delalande , Al Viro , linux-fsdevel@vger.kernel.org To: "Eric W. Biederman" Return-path: Received: from mail-pd0-f169.google.com ([209.85.192.169]:33389 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753053AbbETXAr (ORCPT ); Wed, 20 May 2015 19:00:47 -0400 Received: by pdbqa5 with SMTP id qa5so85204821pdb.0 for ; Wed, 20 May 2015 16:00:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87bnhedhw5.fsf_-_@x220.int.ebiederm.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, May 20, 2015 at 05:05:30PM -0500, Eric W. Biederman wrote: > This works for me, can you confirm it works for you folks as well? > > Thank you, > Eric Yup, neither reproducer produces the warning anymore. Reported-and-Tested-by: Omar Sandoval > From: "Eric W. Biederman" > Date: Wed, 20 May 2015 16:39:00 -0500 > Subject: [PATCH] vfs: Fix, simpliy and stop using d_dname for the /proc/*/ns/* files. > > Now that these files are no longer in proc we can stop playing games > with d_alloc_pseudo and d_dname. This change causes a couple of user > visible changes: > > - Opening /proc/*/ns/* and then readlink on /proc/self/fd/N now sees a > prepended / in the filename. > > - /proc/mountinfo now gives useful information on what is mounted. > > - Bind mounting /proc/*/ns/*, opening the mounted file, removing the > bind mount, and readlink on /proc/self/fd/N now sees / (as it should) What's the rationale for "/" in this case? (I'm not disagreeing, just looking to learn something.) Thanks, -- Omar