From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Delalande Subject: Re: [PATCH] vfs: Fix, simpliy and stop using d_dname for the /proc/*/ns/* files. Date: Thu, 21 May 2015 01:08:33 +0200 Message-ID: <20150520230833.GD22078@ycc.fr> References: <20150515185820.GQ20468@ycc.fr> <20150520100557.GB32189@mew> <87bnhedhw5.fsf_-_@x220.int.ebiederm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Omar Sandoval , Al Viro , linux-fsdevel@vger.kernel.org To: "Eric W. Biederman" Return-path: Received: from mail-wg0-f42.google.com ([74.125.82.42]:35143 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbbETXIh (ORCPT ); Wed, 20 May 2015 19:08:37 -0400 Received: by wgfl8 with SMTP id l8so68037650wgf.2 for ; Wed, 20 May 2015 16:08:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87bnhedhw5.fsf_-_@x220.int.ebiederm.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, May 20, 2015 at 05:05:30PM -0500, Eric W. Biederman wrote: > Omar Sandoval writes: >> I'm attaching a minimal script that reproduces this on 4.1-rc4. I'm >> taking a look, but Eric or Al will probably figure this out before I get >> the chance :) > > This works for me, can you confirm it works for you folks as well? Yeah, your patch works with our setup and when running our initial test-case as well. Thanks a lot Eric. > From: "Eric W. Biederman" > Date: Wed, 20 May 2015 16:39:00 -0500 > Subject: [PATCH] vfs: Fix, simpliy and stop using d_dname for the /proc/*/ns/* files. > > Now that these files are no longer in proc we can stop playing games > with d_alloc_pseudo and d_dname. This change causes a couple of user > visible changes: > > - Opening /proc/*/ns/* and then readlink on /proc/self/fd/N now sees a > prepended / in the filename. > > - /proc/mountinfo now gives useful information on what is mounted. > > - Bind mounting /proc/*/ns/*, opening the mounted file, removing the > bind mount, and readlink on /proc/self/fd/N now sees / (as it should) > instead of triggering a warning and a kernel stack backtrace from > prepend_path. > > Cc: stable@vger.kernel.org > Reported-by: Ivan Delalande > Reported-by: Omar Sandoval > Signed-off-by: "Eric W. Biederman" Tested-by: Ivan Delalande -- Ivan "Colona" Delalande