* [PATCH vfs] ufs:: ufs_truncate_blocks() can be static
2015-06-17 20:04 [vfs:ufs 143/148] fs/ufs/inode.c:1382:6: sparse: symbol 'ufs_truncate_blocks' was not declared. Should it be static? kbuild test robot
@ 2015-06-17 20:04 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-06-17 20:04 UTC (permalink / raw)
To: Al Viro; +Cc: kbuild-all, linux-fsdevel, Evgeniy Dushistov, linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c
index 443f85e..0e23a67 100644
--- a/fs/ufs/inode.c
+++ b/fs/ufs/inode.c
@@ -1379,7 +1379,7 @@ out:
return err;
}
-void ufs_truncate_blocks(struct inode *inode)
+static void ufs_truncate_blocks(struct inode *inode)
{
if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
S_ISLNK(inode->i_mode)))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [vfs:ufs 143/148] fs/ufs/inode.c:1382:6: sparse: symbol 'ufs_truncate_blocks' was not declared. Should it be static?
@ 2015-06-17 20:04 kbuild test robot
2015-06-17 20:04 ` [PATCH vfs] ufs:: ufs_truncate_blocks() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-06-17 20:04 UTC (permalink / raw)
To: Al Viro; +Cc: kbuild-all, linux-fsdevel, Evgeniy Dushistov, linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git ufs
head: e19b8eadd131ad50c0c033709aba5f3dacd02d3c
commit: 0df3df4fd76a6acd8516175817ce101a5c781df5 [143/148] ufs: move truncate code into inode.c
reproduce:
# apt-get install sparse
git checkout 0df3df4fd76a6acd8516175817ce101a5c781df5
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
fs/ufs/inode.c:131:72: sparse: incorrect type in argument 3 (different type sizes)
fs/ufs/inode.c:131:72: expected unsigned long [usertype] *offsets
fs/ufs/inode.c:131:72: got unsigned int *<noident>
fs/ufs/util.h:197:40: sparse: restricted __fs16 degrades to integer
fs/ufs/util.h:231:40: sparse: restricted __fs16 degrades to integer
>> fs/ufs/inode.c:1382:6: sparse: symbol 'ufs_truncate_blocks' was not declared. Should it be static?
fs/ufs/inode.c: In function 'ufs_frag_map':
fs/ufs/inode.c:131:65: warning: passing argument 3 of 'ufs_block_to_path' from incompatible pointer type
int depth = ufs_block_to_path(inode, frag >> uspi->s_fpbshift, offsets);
^
fs/ufs/inode.c:44:12: note: expected 'sector_t *' but argument is of type 'unsigned int *'
static int ufs_block_to_path(struct inode *inode, sector_t i_block, sector_t offsets[4])
^
fs/ufs/inode.c:69:16: warning: array subscript is above array bounds [-Warray-bounds]
offsets[n++] = i_block & (ptrs - 1);
^
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-17 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-17 20:04 [vfs:ufs 143/148] fs/ufs/inode.c:1382:6: sparse: symbol 'ufs_truncate_blocks' was not declared. Should it be static? kbuild test robot
2015-06-17 20:04 ` [PATCH vfs] ufs:: ufs_truncate_blocks() can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).