linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	trond.myklebust@primarydata.com, Anna.Schumaker@netapp.com
Subject: Re: [GIT PULL] please pull file-locking related changes for v4.2
Date: Mon, 13 Jul 2015 09:38:58 -0400	[thread overview]
Message-ID: <20150713133858.GA1130@fieldses.org> (raw)
In-Reply-To: <20150713064532.04060cba@tlielax.poochiereds.net>

On Mon, Jul 13, 2015 at 06:45:32AM -0400, Jeff Layton wrote:
> The following changes since commit b9243b5a5d2da4eb0a54950f4e2d6272863b48be:
> 
>   Merge branch 'parisc-4.2-1' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux (2015-07-10 16:54:37 -0700)
> 
> are available in the git repository at:
> 
>   git://git.samba.org/jlayton/linux.git tags/locks-v4.2-1
> 
> for you to fetch changes up to ee296d7c5709440f8abd36b5b65c6b3e388538d9:
> 
>   locks: inline posix_lock_file_wait and flock_lock_file_wait (2015-07-13 06:29:11 -0400)
> 
> ----------------------------------------------------------------
> File locking related changes for v4.2 (pile #1)
> 
> I had thought that I was going to get away without a pull request this
> cycle. There was a NFSv4 file locking problem that cropped up that I
> tried to fix in the NFSv4 code alone, but that fix has turned out to be
> problematic. These patches fix this in the correct way.
> 
> Note that this touches some NFSv4 code as well. Ordinarily I'd wait for
> Trond to ACK this, but he's on holiday right now and the bug is rather
> nasty. So I suggest we merge this and if he raises issues with it we
> can sort it out when he gets back.

Sounds reasonable to me.

(And without this my regular NFS testing crashes the client every time.)

--b.

> 
> ----------------------------------------------------------------
> Jeff Layton (5):
>       Revert "nfs: take extra reference to fl->fl_file when running a LOCKU operation"
>       locks: have flock_lock_file take an inode pointer instead of a filp
>       locks: new helpers - flock_lock_inode_wait and posix_lock_inode_wait
>       nfs4: have do_vfs_lock take an inode pointer
>       locks: inline posix_lock_file_wait and flock_lock_file_wait
> 
>  fs/locks.c         | 38 ++++++++++++++++++--------------------
>  fs/nfs/nfs4proc.c  | 18 ++++++++----------
>  include/linux/fs.h | 30 ++++++++++++++++++++----------
>  3 files changed, 46 insertions(+), 40 deletions(-)
> 
> 
> -- 
> Jeff Layton <jlayton@poochiereds.net>

  reply	other threads:[~2015-07-13 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 10:45 [GIT PULL] please pull file-locking related changes for v4.2 Jeff Layton
2015-07-13 13:38 ` J. Bruce Fields [this message]
2015-07-14 17:05   ` Dan Williams
2015-07-14 17:15 ` Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150713133858.GA1130@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=Anna.Schumaker@netapp.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).