From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH 4/4] change sb_writers to use percpu_rw_semaphore
Date: Wed, 22 Jul 2015 23:34:37 +0200
Message-ID: <20150722213437.GA20617@redhat.com>
References: <20150722211513.GA19986@redhat.com> <20150722211541.GA20017@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Al Viro <viro@zeniv.linux.org.uk>,
	Dave Chinner <david@fromorbit.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:34051 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750779AbbGVVga (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 22 Jul 2015 17:36:30 -0400
Content-Disposition: inline
In-Reply-To: <20150722211541.GA20017@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Sorry for noise, but let me say just in case...

On 07/22, Oleg Nesterov wrote:
>
> Perhaps we should also cleanup the usage of ->frozen. It would be
> better to set/clear (say) SB_FREEZE_WRITE with the corresponding
> write-lock held. Currently freeze_super() has to set SB_FREEZE_WRITE
> before sb_wait_write(SB_FREEZE_WRITE) to avoid the race with itself,

"Currently" means "after this change". Before this change we obviously
need to increment ->frozen before sb_wait_write().

> The "From now on, no new normal writers
> can start" removed by this patch was not really correct.

Yes, it was confusing even without this change.

Oleg.