From: Christoph Hellwig <hch@infradead.org>
To: hubcap <hubcap@omnibond.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH V3 11/7] Orangefs: large integer implicitly truncated to unsigned type
Date: Fri, 31 Jul 2015 00:36:22 -0700 [thread overview]
Message-ID: <20150731073622.GA14506@infradead.org> (raw)
In-Reply-To: <1438288381-12327-1-git-send-email-hubcap@logtruck.clemson.edu>
On Thu, Jul 30, 2015 at 04:33:01PM -0400, hubcap wrote:
> From: Mike Marshall <hubcap@omnibond.com>
>
> make.cross ARCH=tile doesn't like "inode->i_bytes = PAGE_CACHE_SIZE;",
> so cast PAGE_CACHE_SIZE to unsigned short.
I don't think this is correct. i_bytes is short because it only
contains the low bits of th size, the rest goes into i_blocks.
You probably want to use inode_set_bytes here instead.
next prev parent reply other threads:[~2015-07-31 7:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1437143897-9069-1-git-send-email-root@logtruck.clemson.edu>
2015-07-24 19:09 ` [PATCH V3 8/7] Orangefs: kernel client update 1 Mike Marshall
2015-07-28 20:27 ` [PATCH V3 9/7] Orangefs: sooth most sparse complaints hubcap
2015-07-29 19:57 ` [PATCH V3 10/7] Orangefs: address problems found by static checker hubcap
2015-07-30 20:33 ` [PATCH V3 11/7] Orangefs: large integer implicitly truncated to unsigned type hubcap
2015-07-31 7:36 ` Christoph Hellwig [this message]
2015-07-31 8:26 ` Al Viro
2015-08-05 19:48 ` [PATCH V3 12/7] Orangefs: use inode_set_bytes for directories hubcap
2015-08-05 19:48 ` [PATCH V2 13/7] fs: orangefs: remove execute priviliges from module params hubcap
2015-08-05 19:48 ` [PATCH V3 14/7] Orangefs: Swap order of include files hubcap
2015-08-06 9:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731073622.GA14506@infradead.org \
--to=hch@infradead.org \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).