linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Matias Bjørling" <mb@lightnvm.io>
Cc: hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	Stephen.Bates@pmcs.com, keith.busch@intel.com,
	"Javier González" <jg@lightnvm.io>
Subject: Re: [PATCH v6 5/5] nvme: LightNVM support
Date: Sun, 2 Aug 2015 09:57:53 +0200	[thread overview]
Message-ID: <20150802075753.GH3720@amd> (raw)
In-Reply-To: <1438082268-13496-6-git-send-email-mb@lightnvm.io>

Hi!

> +struct nvme_nvm_hb_rw {
> +	__u8			opcode;
> +	__u8			flags;
> +	__u16			command_id;
> +	__le32			nsid;
> +	__u64			rsvd2;
> +	__le64			metadata;
> +	__le64			prp1;
> +	__le64			prp2;
> +	__le64			slba;
> +	__le16			length;
> +	__le16			control;
> +	__le32			dsmgmt;
> +	__le64			phys_addr;
> +};

You are not exporting this to userland, so you can get rid of "__"s.

    	    	      	      		       	       	      Pavel
							      
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2015-08-02  7:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 11:17 [PATCH v6 0/5] Support for Open-Channel SSDs Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 1/5] lightnvm: " Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 2/5] lightnvm: Hybrid Open-Channel SSD RRPC target Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 3/5] lightnvm: Hybrid Open-Channel SSD block manager Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 4/5] null_nvm: Lightnvm test driver Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 5/5] nvme: LightNVM support Matias Bjørling
2015-08-02  7:57   ` Pavel Machek [this message]
2015-08-04 12:00     ` Matias
2015-08-04 11:30 ` [PATCH v6 0/5] Support for Open-Channel SSDs Christoph Hellwig
2015-08-04 11:58   ` Matias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150802075753.GH3720@amd \
    --to=pavel@ucw.cz \
    --cc=Stephen.Bates@pmcs.com \
    --cc=axboe@fb.com \
    --cc=hch@infradead.org \
    --cc=jg@lightnvm.io \
    --cc=keith.busch@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).