From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 04/11] ext4: Add ext4_get_block_dax() Date: Wed, 5 Aug 2015 12:03:57 +1000 Message-ID: <20150805020357.GA3902@dastard> References: <1438718285-21168-1-git-send-email-matthew.r.wilcox@intel.com> <1438718285-21168-5-git-send-email-matthew.r.wilcox@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox To: Matthew Wilcox Return-path: Content-Disposition: inline In-Reply-To: <1438718285-21168-5-git-send-email-matthew.r.wilcox@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Aug 04, 2015 at 03:57:58PM -0400, Matthew Wilcox wrote: > From: Matthew Wilcox > > DAX wants different semantics from any currently-existing ext4 > get_block callback. Unlike ext4_get_block_write(), it needs to honour > the 'create' flag, and unlike ext4_get_block(), it needs to be able > to return unwritten extents. So introduce a new ext4_get_block_dax() > which has those semantics. We could also change ext4_get_block_write() > to honour the 'create' flag, but that might have consequences on other > users that I do not currently understand. > > Signed-off-by: Matthew Wilcox Doesn't this make the first patch in the series redundant? Cheers, Dave. -- Dave Chinner david@fromorbit.com