From: Oleg Nesterov <oleg@redhat.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coredump: Replace opencoded set_mask_bits()
Date: Fri, 7 Aug 2015 13:57:10 +0200 [thread overview]
Message-ID: <20150807115710.GA16897@redhat.com> (raw)
In-Reply-To: <1438935406-5762-1-git-send-email-vgupta@synopsys.com>
On 08/07, Vineet Gupta wrote:
>
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1690,15 +1690,10 @@ EXPORT_SYMBOL(set_binfmt);
> */
> void set_dumpable(struct mm_struct *mm, int value)
> {
> - unsigned long old, new;
> -
> if (WARN_ON((unsigned)value > SUID_DUMP_ROOT))
> return;
>
> - do {
> - old = ACCESS_ONCE(mm->flags);
> - new = (old & ~MMF_DUMPABLE_MASK) | value;
> - } while (cmpxchg(&mm->flags, old, new) != old);
> + set_mask_bits(&mm->flags, MMF_DUMPABLE_MASK, value);
> }
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2015-08-07 11:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 8:16 [PATCH] coredump: Replace opencoded set_mask_bits() Vineet Gupta
2015-08-07 11:57 ` Oleg Nesterov [this message]
2015-08-07 14:44 ` Vineet Gupta
2015-08-07 14:57 ` Peter Zijlstra
2015-08-07 15:35 ` Vineet Gupta
2015-08-07 15:45 ` Peter Zijlstra
2015-08-07 15:58 ` Vineet Gupta
2015-08-07 16:09 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807115710.GA16897@redhat.com \
--to=oleg@redhat.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).