From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] fs: Set the size of empty dirs to 0. Date: Wed, 12 Aug 2015 16:18:05 -0400 Message-ID: <20150812201805.GC4496@mtj.duckdns.org> References: <87pp63jcca.fsf@x220.int.ebiederm.org> <878ucrhxi9.fsf@x220.int.ebiederm.org> <20150811184426.GH23408@mtj.duckdns.org> <877fp1hcuj.fsf@x220.int.ebiederm.org> <87fv3pe3zn.fsf@x220.int.ebiederm.org> <87a8txb1k8.fsf@x220.int.ebiederm.org> <871tf9b19v.fsf@x220.int.ebiederm.org> <20150812191515.GA4496@mtj.duckdns.org> <87mvxw46fc.fsf_-_@x220.int.ebiederm.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Linux API , Linux Containers , Greg Kroah-Hartman , Andy Lutomirski , Kenton Varda , Michael Kerrisk-manpages , Richard Weinberger , LINUXFS-ML To: "Eric W. Biederman" Return-path: Content-Disposition: inline In-Reply-To: <87mvxw46fc.fsf_-_-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Aug 12, 2015 at 03:07:19PM -0500, Eric W. Biederman wrote: > > Before the make_empty_dir_inode calls were introduce into proc, sysfs, > and sysctl those directories when stated reported an i_size of 0. > make_empty_dir_inode started reporting an i_size of 2. At least one > userspace application depended on stat returning i_size of 0. So modify > make_empty_dir_inode to cause an i_size of 0 to be reported for these > directories. > > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Reproted-by: Tejun Heo ^^^ > Signed-off-by: "Eric W. Biederman" Acked-by: Tejun Heo Thanks. -- tejun