linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>, Eryu Guan <eguan@redhat.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com, axboe@fb.com,
	Jan Kara <jack@suse.com>,
	linux-fsdevel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes
Date: Mon, 17 Aug 2015 16:02:54 -0400	[thread overview]
Message-ID: <20150817200254.GG21075@mtj.duckdns.org> (raw)
In-Reply-To: <20150814111408.GB8710@quack.suse.cz>

Hello, Jan.

On Fri, Aug 14, 2015 at 01:14:09PM +0200, Jan Kara wrote:
> So the patch looks good to me. But the fact that is fixes Eryu's problem
> means there is something fishy going on. Either inodes get wrongly attached

Seriously, it shouldn't affect size syncing or xfs but then again my
understanding of xfs is severely limited.

> to b_dirty_time list or bdi_has_dirty_io() somehow misbehaves only
> temporarily and we don't catch it with the debug patch.
> 
> Can we add a test to wb_has_dirty_io() to also check whether it matches
> bdi_has_dirty_io()? Since Eryu doesn't use lazytime (I assume, Eryu, please
> speak up if you do), we could also warn if b_dirty_time lists get
> non-empty. Hmm?

Sure, will prep a patch soon.

Thanks.

-- 
tejun

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2015-08-17 20:02 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150812101204.GE17933@dhcp-13-216.nay.redhat.com>
2015-08-13  0:44 ` generic/04[89] fail on XFS due to change in writeback code [4.2-rc1 regression] Dave Chinner
2015-08-13 15:34   ` Tejun Heo
2015-08-13 19:16     ` Tejun Heo
2015-08-13 22:44   ` [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes Tejun Heo
2015-08-14 11:14     ` Jan Kara
2015-08-14 15:14       ` Damien Wyart
2015-08-17 20:00         ` Tejun Heo
2015-08-18  5:33           ` Damien Wyart
2015-08-17 20:02       ` Tejun Heo [this message]
2015-08-18  9:16         ` Jan Kara
2015-08-18 17:47           ` Tejun Heo
2015-08-18 19:54             ` Tejun Heo
2015-08-18 21:56               ` Dave Chinner
2015-08-20  6:12                 ` Eryu Guan
2015-08-20 14:01                   ` Eryu Guan
2015-08-20 14:36                   ` Eryu Guan
2015-08-20 14:37                     ` Eryu Guan
2015-08-20 16:55                       ` Tejun Heo
2015-08-20 23:04                         ` Dave Chinner
2015-08-24 18:10                           ` Tejun Heo
2015-08-24 22:27                             ` Dave Chinner
2015-08-24 22:53                               ` Tejun Heo
2015-08-21 10:20                 ` Eryu Guan
2015-08-22  0:30                   ` Dave Chinner
2015-08-22  4:46                     ` Eryu Guan
2015-08-24  1:11                       ` Dave Chinner
2015-08-24  3:18                         ` Eryu Guan
2015-08-24  6:24                           ` Dave Chinner
2015-08-24  8:34                             ` Eryu Guan
2015-08-24  8:55                               ` Dave Chinner
2015-08-24  9:19                             ` Jan Kara
2015-08-24 14:51                               ` Tejun Heo
2015-08-24 17:11                                 ` Tejun Heo
2015-08-24 19:08                                   ` Jan Kara
2015-08-24 19:32                                     ` Tejun Heo
2015-08-24 21:09                                       ` Jan Kara
2015-08-24 21:45                                         ` Tejun Heo
2015-08-24 22:54                                           ` Tejun Heo
2015-08-24 22:57                                           ` Dave Chinner
2015-08-25 18:11     ` [PATCH v2 block/for-linus] writeback: sync_inodes_sb() must write out I_DIRTY_TIME inodes and always call wait_sb_inodes() Tejun Heo
2015-08-25 20:37       ` Jens Axboe
2015-08-26  9:00       ` Jan Kara
2015-08-13 23:24   ` generic/04[89] fail on XFS due to change in writeback code [4.2-rc1 regression] Tejun Heo
2015-08-14  6:19     ` Eryu Guan
2015-08-17 20:27       ` Tejun Heo
2015-08-18  3:57         ` Eryu Guan
2015-08-18  5:31           ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150817200254.GG21075@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=eguan@redhat.com \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=kernel-team@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).