From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes Date: Mon, 17 Aug 2015 16:02:54 -0400 Message-ID: <20150817200254.GG21075@mtj.duckdns.org> References: <20150812101204.GE17933@dhcp-13-216.nay.redhat.com> <20150813004435.GN3902@dastard> <20150813224415.GG4496@mtj.duckdns.org> <20150814111408.GB8710@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Jens Axboe , Eryu Guan , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, axboe@fb.com, Jan Kara , linux-fsdevel@vger.kernel.org, kernel-team@fb.com To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20150814111408.GB8710@quack.suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-fsdevel.vger.kernel.org Hello, Jan. On Fri, Aug 14, 2015 at 01:14:09PM +0200, Jan Kara wrote: > So the patch looks good to me. But the fact that is fixes Eryu's problem > means there is something fishy going on. Either inodes get wrongly attached Seriously, it shouldn't affect size syncing or xfs but then again my understanding of xfs is severely limited. > to b_dirty_time list or bdi_has_dirty_io() somehow misbehaves only > temporarily and we don't catch it with the debug patch. > > Can we add a test to wb_has_dirty_io() to also check whether it matches > bdi_has_dirty_io()? Since Eryu doesn't use lazytime (I assume, Eryu, please > speak up if you do), we could also warn if b_dirty_time lists get > non-empty. Hmm? Sure, will prep a patch soon. Thanks. -- tejun _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs