From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eryu Guan Subject: Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes Date: Sat, 22 Aug 2015 12:46:09 +0800 Message-ID: <20150822044609.GM17933@dhcp-13-216.nay.redhat.com> References: <20150813004435.GN3902@dastard> <20150813224415.GG4496@mtj.duckdns.org> <20150814111408.GB8710@quack.suse.cz> <20150817200254.GG21075@mtj.duckdns.org> <20150818091603.GA12317@quack.suse.cz> <20150818174718.GA15739@mtj.duckdns.org> <20150818195439.GB15739@mtj.duckdns.org> <20150818215611.GD3902@dastard> <20150821102053.GL17933@dhcp-13-216.nay.redhat.com> <20150822003025.GS3902@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Jens Axboe , Jan Kara , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, axboe@fb.com, Tejun Heo , Jan Kara , linux-fsdevel@vger.kernel.org, kernel-team@fb.com To: Dave Chinner Return-path: Content-Disposition: inline In-Reply-To: <20150822003025.GS3902@dastard> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-fsdevel.vger.kernel.org On Sat, Aug 22, 2015 at 10:30:25AM +1000, Dave Chinner wrote: > On Fri, Aug 21, 2015 at 06:20:53PM +0800, Eryu Guan wrote: [snip] > > Eryu, can you try again, this time manually specifying the writeback > tracepoints so you exclude the really noisy ones? You can also drop > the xfs_file_buffered_write and xfs_file_fsync tracepoints as well, > as we can see that the incoming side of the code is doing the right > thing.... I excluded the writeback tracepoints you mentioned writeback_mark_inode_dirty writeback_dirty_inode_start writeback_dirty_inode writeback_dirty_page writeback_write_inode and left all other writeback tracepoints enabled, also dropped xfs_file_buffered_write and xfs_file_fsync. This time I can reproduce generic/048 quickly and please download the trace info from below http://128.199.137.77/writeback-v2/ Thanks, Eryu _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs