linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: dsterba@suse.cz, Peng Tao <tao.peng@primarydata.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Christoph Hellwig <hch@infradead.org>, Zach Brown <zab@zabbo.net>,
	Darren Hart <dvhart@linux.intel.com>,
	Bruce Fields <bfields@fieldses.org>,
	Jeff Layton <jeff.layton@primarydata.com>,
	linux-btrfs@vger.kernel.org,
	Devel FS Linux <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC 02/11] vfs/btrfs: add .clone_range file operation
Date: Wed, 26 Aug 2015 06:07:12 -0700	[thread overview]
Message-ID: <20150826130712.GA6958@infradead.org> (raw)
In-Reply-To: <20150826130057.GW10756@suse.cz>

On Wed, Aug 26, 2015 at 03:00:57PM +0200, David Sterba wrote:
> > I thought it breaks ABI if we choose a different value for the type
> > field of the ioctl. Am I misunderstanding it?
> 
> The ioctl is now private to btrfs, you're going to define the new ABI so
> it IMHO should use the generic filesystem ioctl magic/namespace.

No, that's completly backwards.  We move up ioctls that have prooven
to be generally useful to common code, and we've done that with various
extN and XFS ones already.

      reply	other threads:[~2015-08-26 13:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1440516829-116041-1-git-send-email-tao.peng@primarydata.com>
     [not found] ` <1440516829-116041-1-git-send-email-tao.peng-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2015-08-25 15:33   ` [PATCH RFC 01/11] vfs: pull btrfs clone API to vfs layer Peng Tao
2015-08-26  1:40     ` Peng Tao
2015-08-26  1:50     ` Dave Chinner
2015-08-26  1:59       ` Dave Chinner
2015-08-26  4:09     ` Darrick J. Wong
     [not found]       ` <20150826040943.GC10038-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2015-08-26  8:03         ` Peng Tao
2015-08-25 15:33 ` [PATCH RFC 02/11] vfs/btrfs: add .clone_range file operation Peng Tao
     [not found]   ` <1440516829-116041-3-git-send-email-tao.peng-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2015-08-26  8:01     ` David Sterba
     [not found]       ` <20150826080111.GV10756-1ReQVI26iDCaZKY3DrU6dA@public.gmane.org>
2015-08-26  8:31         ` Peng Tao
     [not found]           ` <CAKVebiWy6S4ri8_V+SuT+mnyTKjiubPS49k3LHF2Csh2TVf_SQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-26 13:00             ` David Sterba
2015-08-26 13:07               ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150826130712.GA6958@infradead.org \
    --to=hch@infradead.org \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=dsterba@suse.cz \
    --cc=dvhart@linux.intel.com \
    --cc=jeff.layton@primarydata.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=tao.peng@primarydata.com \
    --cc=trond.myklebust@primarydata.com \
    --cc=zab@zabbo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).