From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>,
Eric Van Hensbergen <ericvh@gmail.com>,
Ron Minnich <rminnich@sandia.gov>,
Latchesar Ionkov <lucho@ionkov.net>,
v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH 3/5] 9p: Simplify the xattr handlers
Date: Wed, 16 Sep 2015 07:14:06 -0700 [thread overview]
Message-ID: <20150916141406.GA16005@infradead.org> (raw)
In-Reply-To: <1441367842-25079-4-git-send-email-agruenba@redhat.com>
> + const char *full_name = name - XATTR_SECURITY_PREFIX_LEN;
Please add something like an xattr_full_name() helper to xattr.h that
does this in one place and with proper documentation.
Otherwise looks fine.
next prev parent reply other threads:[~2015-09-16 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 11:57 [PATCH 0/5] Pass xattr handler to xattr handler operations Andreas Gruenbacher
2015-09-04 11:57 ` [PATCH 1/5] ubifs: Remove unused "security.*" xattr handler Andreas Gruenbacher
2015-09-04 11:57 ` [PATCH 2/5] hfsplus: Remove unused xattr handler list operations Andreas Gruenbacher
2015-09-04 11:57 ` [PATCH 3/5] 9p: Simplify the xattr handlers Andreas Gruenbacher
2015-09-16 14:14 ` Christoph Hellwig [this message]
2015-09-21 7:30 ` Aneesh Kumar K.V
2015-09-04 11:57 ` [PATCH 4/5] xattr handlers: Pass handler to operations instead of flags Andreas Gruenbacher
2015-09-16 14:16 ` Christoph Hellwig
2015-09-04 11:57 ` [PATCH 5/5] xattr handlers: Some simplifications Andreas Gruenbacher
2015-09-16 14:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916141406.GA16005@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=andreas.gruenbacher@gmail.com \
--cc=dedekind1@gmail.com \
--cc=ericvh@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lucho@ionkov.net \
--cc=richard@nod.at \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).