From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 3/5] 9p: Simplify the xattr handlers Date: Wed, 16 Sep 2015 07:14:06 -0700 Message-ID: <20150916141406.GA16005@infradead.org> References: <1441367842-25079-1-git-send-email-agruenba@redhat.com> <1441367842-25079-4-git-send-email-agruenba@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Viro , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Artem Bityutskiy , Adrian Hunter , linux-mtd@lists.infradead.org, Richard Weinberger , Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , v9fs-developer@lists.sourceforge.net To: Andreas Gruenbacher Return-path: Content-Disposition: inline In-Reply-To: <1441367842-25079-4-git-send-email-agruenba@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > + const char *full_name = name - XATTR_SECURITY_PREFIX_LEN; Please add something like an xattr_full_name() helper to xattr.h that does this in one place and with proper documentation. Otherwise looks fine.