From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 4/5] xattr handlers: Pass handler to operations instead
 of flags
Date: Wed, 16 Sep 2015 07:16:14 -0700
Message-ID: <20150916141614.GB16005@infradead.org>
References: <1441367842-25079-1-git-send-email-agruenba@redhat.com>
 <1441367842-25079-5-git-send-email-agruenba@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-mtd@lists.infradead.org, Richard Weinberger <richard@nod.at>,
	Eric Van Hensbergen <ericvh@gmail.com>,
	Ron Minnich <rminnich@sandia.gov>,
	Latchesar Ionkov <lucho@ionkov.net>,
	v9fs-developer@lists.sourceforge.net
To: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1441367842-25079-5-git-send-email-agruenba@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Fri, Sep 04, 2015 at 01:57:21PM +0200, Andreas Gruenbacher wrote:
> The xattr_handler operations are currently all passed a file system specific
> flags value which the operations can use to disambiguate between different
> handlers; some file systems use that to distinguish the xattr namespace, for
> example.  In some oprations, it would be useful to also have access to the
> handler prefix.  To allow that, pass a pointer to the handler to operations
> instead of the flags value alone.

Looks ok, but the more usual calling convention would be to pass
the handler as the first argument.