From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug() Date: Thu, 17 Sep 2015 08:07:04 +1000 Message-ID: <20150916220704.GM3902@dastard> References: <20150911231636.GC4150@ret.masoncoding.com> <20150912230027.GE4150@ret.masoncoding.com> <20150913231258.GS26895@dastard> <20150916151621.GA8624@ret.masoncoding.com> <20150916195806.GD29530@quack.suse.cz> <20150916200012.GB8624@ret.masoncoding.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Chris Mason , Jan Kara , Linus Torvalds , Josef Bacik , LKML , linux-fsdevel , Neil Brown , Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20150916200012.GB8624@ret.masoncoding.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Sep 16, 2015 at 04:00:12PM -0400, Chris Mason wrote: > On Wed, Sep 16, 2015 at 09:58:06PM +0200, Jan Kara wrote: > > On Wed 16-09-15 11:16:21, Chris Mason wrote: > > > Short version, Linus' patch still gives bigger IOs and similar perf to > > > Dave's original. I should have done the blktrace runs for 60 seconds > > > instead of 30, I suspect that would even out the average sizes between > > > the three patches. > > > > Thanks for the data Chris. So I guess we are fine with what's currently in, > > right? > > Looks like it works well to me. Graph looks good, though I'll confirm it on my test rig once I get out from under the pile of email and other stuff that is queued up after being away for a week... Cheers, Dave. -- Dave Chinner david@fromorbit.com